Commit graph

710 commits

Author SHA1 Message Date
Norbert Renner
5ad12a7c68 Refactor common track loading parts (#312)
- common track style
- TracksLoader now also adds points as POIs
- RouteLoaderConverter does not add route points as POI
2020-06-25 17:15:09 +02:00
Norbert Renner
fa59a44a5e
Merge pull request #317 from rkflx/pr/reuse-shortcut-translations
Combine and reuse translations for keyboard shortcuts
2020-06-22 16:28:44 +02:00
Henrik Fehlauer
09f987ea07 Combine and reuse translations for keyboard shortcuts
Using i18next's "nesting" and "interpolation" features should reduce the
overall number of strings to translate, as well as provide a
standardized pattern for shortcut tooltips (if applicable).

Note that this approach is still allowing for flexibility regarding
differently structured sentences in each language.

Resolves #315
2020-06-21 18:00:00 +00:00
Henrik Fehlauer
e3a9f6206f Switch to next tab with Shift+T shortcut even if tab is currently closed
Often users can remember what the recently opened tab was, so we can
switch to and open the next tab immediately, saving one keypress. There
is a dedicated shortcut (T) for only opening a tab, after all.

While the previous behavior for Shift+T (open tab without switching to
next if currently closed) was by intention, user testing found that the
new approach might be more desirable.
2020-06-20 18:00:00 +00:00
Norbert Renner
77f1b5f0af
Merge pull request #314 from rkflx/pr/add-and-fix-shortcuts
Add more keyboard shortcuts and fix various shortcut related issues
2020-06-19 21:26:13 +02:00
Henrik Fehlauer
f2dd3b95a4 Add warning regarding yarn build i18next / gulp i18next
Also mention what is done by maintainers.
2020-06-19 18:00:00 +00:00
The Ripper
0d6cd61b1f
Load Track from file and add as Route (#312) 2020-06-19 18:19:42 +02:00
Norbert Renner
007761b4b1 release: 0.12.0 2020-06-19 11:18:34 +02:00
Norbert Renner
1e18315e4f Update translations 2020-06-19 11:14:23 +02:00
Norbert Renner
38586faca9 Update changelog for 0.12.0 2020-06-18 20:25:56 +02:00
Henrik Fehlauer
8a66a816f7 Run yarn lint, yarn prettier and yarn build i18next
0d6cd61 was still missing some style fixes, making `yarn` touch
unrelated files on a subsequent `git commit`.
2020-06-18 18:00:00 +00:00
Norbert Renner
309f4bd33b Update leaflet-routing to bumped version commit
Yarn seems not to use latest commit, despite saying so, when version is unchanged.
2020-06-17 18:35:37 +02:00
Norbert Renner
de3d355c0c Add contact language hint to about dialog 2020-06-17 17:51:40 +02:00
Norbert Renner
ebaba664d2 Improve mobile stats (#302)
- flex-wrap instead of hard character break
- minimal margin
- add missing breakpoint for space
2020-06-17 10:39:53 +02:00
Norbert Renner
4ef43652df
Merge pull request #313 from rkflx/pr/polish-and-fix-route-quality-visuals
Polish color coding + analysis tab visuals and fix a couple of related bugs
2020-06-17 10:30:51 +02:00
Henrik Fehlauer
b8b1e436e6 Add shortcut to toggle elevation chart
Press 'E' to show/hide the elevation chart.
2020-06-14 18:00:00 +00:00
Marcus Jaschen
8621c4403b add hint for the "M" keyboard shortcut to the opacity slider tooltip 2020-06-14 19:18:43 +02:00
Henrik Fehlauer
844a9038ee Add shortcuts to toggle sidebar and switch tabs
The 'T' key will show/hide the most recent sidebar tab.

Pressing 'Shift+T' will switch to the next sidebar tab, possibly
wrapping around to the first tab.

If the Itinerary tab is hidden, it will be skipped.
2020-06-13 18:00:00 +00:00
Henrik Fehlauer
e56d213931 Add shortcut to show about dialog
Press 'H' to get to the helpful about dialog.
2020-06-12 18:00:00 +00:00
Norbert Renner
71317b84e4 Fix analysis sorting
Return value of the sort compare function is defined as value less, equal or greater than 0, not as boolean.
2020-06-12 10:57:41 +02:00
Henrik Fehlauer
d106552ad3 Add shortcuts to load tracks and no-go areas
Press 'O' or 'Shift+O' to open/load tracks or no-go areas respectively.
2020-06-11 18:00:00 +00:00
Henrik Fehlauer
a420ad5c0b Add shortcut to export route
Press 'X' to trigger the export route dialog.

Automatically populating the trackname field should work too.
2020-06-10 18:00:00 +00:00
Henrik Fehlauer
6da520ed4d Add shortcut to toggle profile switcher
Press 'G' to open the profile switcher, select a profile with the arrow
keys, apply with 'Enter' and close the switcher with 'Escape'.

While 'T' and 'P' will be / were already taken, 'G' is at least easily
reachable with the left hand for users using a mouse with their right
hand at the same time.

Since Bootstrap keeps updating the tooltip when changing options in the
dropdown (which is useful in case the text is longer than the width of
the control), the shortcut text needs to be applied dynamically too.
2020-06-09 18:00:00 +00:00
Michael Scherer
eb0e0d6f1e
-p(ort) is needed for docker-compose run command (#309) 2020-06-08 20:12:59 +02:00
Henrik Fehlauer
ba0bb39fd5 Add shortcut to toggle Strava layer
Press 'S' to show the Strava buttons (if the API key has been set) as
well as the Strava segments layer (once it has been fetched).

Note that fetching and updating data from Strava still needs to be
triggered manually by clicking the respective biking or running button.
2020-06-08 18:00:00 +00:00
Norbert Renner
a85992d927
Merge pull request #308 from schmic/feature/docker-compose-development
add docker-compose tasks for development
2020-06-08 18:33:07 +02:00
Norbert Renner
42899beb26
Merge pull request #307 from schmic/feature/vs-code-workspace-configuration
add VS Code settings, launch and extension recommendations
2020-06-08 18:27:01 +02:00
Michael Scherer
11917dc7ee add docker-compose tasks for development 2020-06-08 15:11:56 +02:00
Michael Scherer
e161c5c40c add VS Code settings, launch and extension recommondations 2020-06-08 14:34:13 +02:00
Norbert Renner
bed388df40
Merge pull request #305 from bagage/docs/contributing
Add CONTRIBUTING.md
2020-06-08 11:38:15 +02:00
Norbert Renner
fcc902b3f9 Update en.json by i18next
i18next removed new dynamic keys under "sidebar.analysis.data" by PR #304, leaving them off for now; the rest is resorting
2020-06-08 10:58:52 +02:00
Norbert Renner
f37489cf26
Merge pull request #304 from mjaschen/feature/track-analysis
Add sidebar tab with route analysis data
2020-06-08 09:08:03 +02:00
Gautier P
db87c170be Add CONTRIBUTING.md 2020-06-07 22:59:51 +02:00
Henrik Fehlauer
e4e1c8a19e Add shortcut for clear route dialog
Use 'Backspace' to show the dialog allowing to clear the route.

The 'Del' key could then be used in the future to possibly allow to
delete individual selected items like POIs or no-go areas.
2020-06-07 18:00:00 +00:00
Marcus Jaschen
fc54c65e23 Add sidebar tab with route analysis data
- adds a new analysis tab in the sidebar
- the analysis tab shows length distribution for different way types, surface, and smoothness
- table rows can be hovered/clicked to highlight the according segments on the map (similar behaviour as the detailed data table)
- localization is implemented for `de` and `en`
- the method for finding segment edges was extracted from `js/control/TrackMessages.js` into `js/util/TrackEdges.js` as it's used in the new analysis class too (the Gulp config was changed to reflect that)

Notes:

I had the idea to use the *DataTable* plugin for rendering the tables but decided against it. The only meaningful way to sort such a table is by the length column and that's already the case. So it's just three plain, old HTML tables, rendered by jQuery.

For meaningful statistics the `processUnusedTags` setting has to be enabled in the routing profile. Only in this case the BRouter backend includes all needed tags (`highway`, `surface`, and `smoothness`) for *every* route segment in the response. I’ve enabled that setting for all profiles at my BRouter-web instance at <https://brouter.m11n.de/>.
2020-06-07 16:56:50 +02:00
Norbert Renner
b181649dff
Merge pull request #303 from stesie/mute-opacity
Allow to mute route display
2020-06-07 14:18:54 +02:00
Stefan Siegl
64202a451c
Allow to mute route 2020-06-06 21:47:58 +02:00
Henrik Fehlauer
29530919b5 Stop deleting points once there are no more points left
Prevents "Uncaught TypeError: Cannot read property 'off' of null"
in L.Routing.js
2020-06-06 18:00:00 +00:00
Norbert Renner
32d4a26dfd Fix nogo drawing for mobile Chrome, fixes #259 2020-06-05 20:11:36 +02:00
Henrik Fehlauer
48f8fe3524 Add shortcut to delete last point
Press 'Z' to undo adding the last point.
2020-06-05 18:00:00 +00:00
Henrik Fehlauer
a852acbfce Add shortcut to create no-go areas
Press 'N' to initiate drawing a no-go area. 'Escape' will cancel,
similar to how drawing a route works.
2020-06-04 18:00:00 +00:00
Norbert Renner
f197fb31be Exclude loaded tracks from URL hash 2020-06-03 20:24:17 +02:00
Henrik Fehlauer
2848e4dd36 Add shortcut to reverse route
Press 'R' to swap start and end of the route.
2020-06-03 18:00:00 +00:00
Norbert Renner
9fd9a52a8c Set track color yellow for CyclOSM (#297) 2020-06-02 22:09:22 +02:00
Henrik Fehlauer
37ab05310b Add shortcut for geocoder search field
Press 'F', type a query and press 'Enter' to find places effortlessly.

Note that the button already triggers on mousedown events, even though
by convention it should react on mouseup (i.e. a regular click)
only. However, that's an issue in the external dependency, and can
be worked around for now.
2020-06-02 18:00:00 +00:00
Henrik Fehlauer
f23e3751b5 Allow translation of the search field placeholder text
It was not translated before, since the string was coming from an
external dependency.
2020-06-01 18:00:00 +00:00
Henrik Fehlauer
fd97019fdc Add shortcut to trigger geolocation
Press 'L' to initiate the "Show me where I am" function.
2020-05-31 18:00:00 +00:00
Henrik Fehlauer
8e78c858c1 Add shortcut to toggle color coding button
Press 'C' repeatedly to switch between the various color coding options.
When the last one is reached, we show the regular route again.
2020-05-30 18:00:00 +00:00
Henrik Fehlauer
d6c648d3eb Fix mute shortcut not working for color coded routes
The mute shortcut would only work for regular routes before.

Note that no-go areas, POIs and tracks continue to be unaffected
by muting, so e.g. peeking at a track below the route is still possible.
2020-05-29 18:00:00 +00:00
Henrik Fehlauer
08c8cfa8be Prevent more accidental shortcut triggers
Do not allow browser keyboard shortcuts to trigger route functions,
e.g. pressing Ctrl+P triggers printing in most browsers, but should not
at the same time switch BRouter-Web to POI mode. This can be prevented
by filtering for modifiers.

In the same fashion, when modal dialogs or dropdowns are open it should
not be possible to activate map functions in the background now.

Finally, inhibit shortcuts in number input fields too, as found in the
editable number input fields in the customize profile options.
Previously only regular text input fields were protected.

To make those checks easier to use, they are deduplicated and moved to
Util.js.
2020-05-28 18:00:00 +00:00