From 0b15018722c56bd4642c0920c60aa24c291e87a3664dd8496657d113703299d1 Mon Sep 17 00:00:00 2001 From: Ben Varick Date: Fri, 7 Nov 2025 08:53:18 -0800 Subject: [PATCH 1/2] Revert "made data and config directories dynamic, switched from DockerRunLauncher to DefaultRunLauncher" This reverts commit f85935dd75d831c5db3864ef200cc380637c4d42b1ea50dd5aef080cf0036c06. --- dagster.yaml | 21 +++++++++++++++++++-- docker-compose.yaml | 20 +++++++++----------- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/dagster.yaml b/dagster.yaml index a9b563c..b5ac980 100644 --- a/dagster.yaml +++ b/dagster.yaml @@ -8,10 +8,27 @@ run_coordinator: class: QueuedRunCoordinator config: max_concurrent_runs: 5 + tag_concurrency_limits: + - key: "operation" + value: "example" + limit: 5 run_launcher: - module: dagster.core.launcher - class: DefaultRunLauncher + module: dagster_docker + class: DockerRunLauncher + config: + env_vars: + - DAGSTER_POSTGRES_USER + - DAGSTER_POSTGRES_PASSWORD + - DAGSTER_POSTGRES_DB + - MOBILITY_DB_REFRESH_TOKEN + network: dagster + container_kwargs: + volumes: # Make docker client accessible to any launched containers as well + - /var/run/docker.sock:/var/run/docker.sock + - /tmp/io_manager_storage:/tmp/io_manager_storage + - /home/ben/code/gtfs-dagster/data:/opt/dagster/app/data + - /home/ben/code/gtfs-dagster/config:/opt/dagster/app/config run_storage: module: dagster_postgres.run_storage diff --git a/docker-compose.yaml b/docker-compose.yaml index 28065cc..cdb1af9 100644 --- a/docker-compose.yaml +++ b/docker-compose.yaml @@ -14,7 +14,7 @@ services: env_file: - .env volumes: - - ${POSTGRES_DIRECTORY}:/var/lib/postgresql/data + - ./postgres_data:/var/lib/postgresql/data networks: - dagster healthcheck: @@ -45,8 +45,8 @@ services: env_file: - .env volumes: - - ${DATA_DIRECTORY}:/opt/dagster/app/data - - ${CONFIG_DIRECTORY}:/opt/dagster/app/config + - ./data:/opt/dagster/app/data + - ./config:/opt/dagster/app/config networks: - dagster @@ -74,10 +74,9 @@ services: DAGSTER_POSTGRES_DB: ${POSTGRES_DB} env_file: - .env -## Don't need for DefaultRunLauncher, uncomment for DockerRunLauncher -# volumes: -# - /var/run/docker.sock:/var/run/docker.sock -# - /tmp/io_manager_storage:/tmp/io_manager_storage + volumes: # Make docker client accessible so we can terminate containers from the webserver + - /var/run/docker.sock:/var/run/docker.sock + - /tmp/io_manager_storage:/tmp/io_manager_storage networks: - dagster depends_on: @@ -103,10 +102,9 @@ services: DAGSTER_POSTGRES_DB: ${POSTGRES_DB} env_file: - .env -## Don't need for DefaultRunLauncher, uncomment for DockerRunLauncher -# volumes: -# - /var/run/docker.sock:/var/run/docker.sock -# - /tmp/io_manager_storage:/tmp/io_manager_storage + volumes: # Make docker client accessible so we can launch containers using host docker + - /var/run/docker.sock:/var/run/docker.sock + - /tmp/io_manager_storage:/tmp/io_manager_storage networks: - dagster depends_on: From d32c2b4d336653a31bcab2f31a15ee888145556b4833cd2b28a46247c60eaac1 Mon Sep 17 00:00:00 2001 From: Ben Varick Date: Fri, 7 Nov 2025 09:28:46 -0800 Subject: [PATCH 2/2] added volumes_from kwarg to run_launcher --- dagster.yaml | 6 +++--- docker-compose.yaml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dagster.yaml b/dagster.yaml index b5ac980..4f4718e 100644 --- a/dagster.yaml +++ b/dagster.yaml @@ -24,11 +24,11 @@ run_launcher: - MOBILITY_DB_REFRESH_TOKEN network: dagster container_kwargs: - volumes: # Make docker client accessible to any launched containers as well + volumes_from: + - dagster_code + volumes: - /var/run/docker.sock:/var/run/docker.sock - /tmp/io_manager_storage:/tmp/io_manager_storage - - /home/ben/code/gtfs-dagster/data:/opt/dagster/app/data - - /home/ben/code/gtfs-dagster/config:/opt/dagster/app/config run_storage: module: dagster_postgres.run_storage diff --git a/docker-compose.yaml b/docker-compose.yaml index cdb1af9..c128a99 100644 --- a/docker-compose.yaml +++ b/docker-compose.yaml @@ -44,9 +44,9 @@ services: MOBILITY_DB_REFRESH_TOKEN: ${MOBILITY_DB_REFRESH_TOKEN} env_file: - .env - volumes: - - ./data:/opt/dagster/app/data - - ./config:/opt/dagster/app/config + volumes: # these volumes are also passed on to the containers that are spawned to run the assets. + - ${DATA_DIRECTORY}:/opt/dagster/app/data + - ${CONFIG_DIRECTORY}:/opt/dagster/app/config networks: - dagster