Enable PMD rule LooseCoupling and fix violations

This commit is contained in:
Manuel Fuhr 2022-11-13 12:38:30 +01:00
parent c75a8cb703
commit 30be64cbbe
26 changed files with 64 additions and 50 deletions

View file

@ -1,6 +1,6 @@
package btools.util;
import java.util.ArrayList;
import java.util.List;
/**
* Memory efficient Map to map a long-key to an object-value
@ -243,7 +243,7 @@ public class CompactLongMap<V> {
return false;
}
protected void moveToFrozenArrays(long[] faid, ArrayList<V> flv) {
protected void moveToFrozenArrays(long[] faid, List<V> flv) {
for (int i = 1; i < MAXLISTS; i++) {
pa[i] = 0;
}

View file

@ -1,6 +1,7 @@
package btools.util;
import java.util.ArrayList;
import java.util.List;
/**
* Special Memory efficient Map to map a long-key to
@ -16,7 +17,7 @@ import java.util.ArrayList;
* @author ab
*/
public class DenseLongMap {
private ArrayList<byte[]> blocklist = new ArrayList<byte[]>(4096);
private List<byte[]> blocklist = new ArrayList<byte[]>(4096);
private int blocksize; // bytes per bitplane in one block
private int blocksizeBits;

View file

@ -12,7 +12,7 @@ import java.util.List;
*/
public class FrozenLongMap<V> extends CompactLongMap<V> {
private long[] faid;
private ArrayList<V> flv;
private List<V> flv;
private int size = 0;
private int p2size; // next power of 2 of size

View file

@ -1,7 +1,7 @@
package btools.util;
import java.util.List;
import java.util.ArrayList;
import java.util.List;
/**
* Behaves like an Array of list
@ -10,7 +10,7 @@ import java.util.ArrayList;
* @author ab
*/
public class LazyArrayOfLists<E> {
private ArrayList<ArrayList<E>> lists;
private List<ArrayList<E>> lists;
public LazyArrayOfLists(int size) {
lists = new ArrayList<ArrayList<E>>(size);