ben/brouter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Enable PMD rule LooseCoupling and fix violations

Browse source
This commit is contained in:
Manuel Fuhr 2022-11-13 12:38:30 +01:00
parent c75a8cb703
commit 30be64cbbe
26 changed files with 64 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

3
brouter-mapaccess/src/main/java/btools/mapaccess/NodesCache.java
View file

@ -9,6 +9,7 @@ import java.io.File;
import java.io.IOException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import btools.codec.DataBuffers;
import btools.codec.MicroCache;
@ -26,7 +27,7 @@ public final class NodesCache {
private boolean forceSecondaryData;
private String currentFileName;
private HashMap<String, PhysicalFile> fileCache;
private Map<String, PhysicalFile> fileCache;
private DataBuffers dataBuffers;
private OsmFile[][] fileRows;

16
brouter-mapaccess/src/main/java/btools/mapaccess/OsmNodesMap.java
View file

@ -7,11 +7,13 @@ package btools.mapaccess;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import btools.util.ByteArrayUnifier;
public final class OsmNodesMap {
private HashMap<OsmNode, OsmNode> hmap = new HashMap<OsmNode, OsmNode>(4096);
private Map<OsmNode, OsmNode> hmap = new HashMap<OsmNode, OsmNode>(4096);
private ByteArrayUnifier abUnifier = new ByteArrayUnifier(16384, false);
@ -122,11 +124,7 @@ public final class OsmNodesMap {
return total <= currentmaxmem;
}
private void addActiveNode(ArrayList<OsmNode> nodes2check, OsmNode n) {
n.visitID = lastVisitID;
nodesCreated++;
nodes2check.add(n);
}
private List<OsmNode> nodes2check;
// is there an escape from this node
// to a hollow node (or destination node) ?
@ -169,7 +167,11 @@ public final class OsmNodesMap {
return false;
}
private ArrayList<OsmNode> nodes2check;
private void addActiveNode(List<OsmNode> nodes2check, OsmNode n) {
n.visitID = lastVisitID;
nodesCreated++;
nodes2check.add(n);
}
public void clearTemp() {
nodes2check = null;