ben/brouter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Enable PMD rule LooseCoupling and fix violations

Browse source
This commit is contained in:
Manuel Fuhr 2022-11-13 12:38:30 +01:00
parent c75a8cb703
commit 30be64cbbe
26 changed files with 64 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

10
brouter-core/src/main/java/btools/router/OsmTrack.java
View file

@ -53,7 +53,7 @@ public final class OsmTrack {
public OsmPathElementHolder nextHolder;
}
public ArrayList<OsmPathElement> nodes = new ArrayList<OsmPathElement>();
public List<OsmPathElement> nodes = new ArrayList<OsmPathElement>();
private CompactLongMap<OsmPathElementHolder> nodesMap;
@ -62,7 +62,7 @@ public final class OsmTrack {
private VoiceHintList voiceHints;
public String message = null;
public ArrayList<String> messageList = null;
public List<String> messageList = null;
public String name = "unset";
@ -113,7 +113,7 @@ public final class OsmTrack {
nodesMap = new FrozenLongMap<OsmPathElementHolder>(nodesMap);
}
private ArrayList<String> aggregateMessages() {
private List<String> aggregateMessages() {
ArrayList<String> res = new ArrayList<String>();
MessageData current = null;
for (OsmPathElement n : nodes) {
@ -135,7 +135,7 @@ public final class OsmTrack {
return res;
}
private ArrayList<String> aggregateSpeedProfile() {
private List<String> aggregateSpeedProfile() {
ArrayList<String> res = new ArrayList<String>();
int vmax = -1;
int vmaxe = -1;
@ -673,7 +673,7 @@ public final class OsmTrack {
}
if (showSpeedProfile) // set in profile
{
ArrayList<String> sp = aggregateSpeedProfile();
List<String> sp = aggregateSpeedProfile();
if (sp.size() > 0) {
sb.append(" \"speedprofile\": [\n");
for (int i = sp.size() - 1; i >= 0; i--) {

2
brouter-core/src/main/java/btools/router/RoutingEngine.java
View file

@ -1078,7 +1078,7 @@ public class RoutingEngine extends Thread {
synchronized (openSet) {
if (guideTrack != null) {
ArrayList<OsmPathElement> nodes = guideTrack.nodes;
List<OsmPathElement> nodes = guideTrack.nodes;
int[] res = new int[nodes.size() * 2];
int i = 0;
for (OsmPathElement n : nodes) {

3
brouter-core/src/main/java/btools/router/VoiceHintList.java
View file

@ -7,11 +7,12 @@
package btools.router;
import java.util.ArrayList;
import java.util.List;
public class VoiceHintList {
private String transportMode;
int turnInstructionMode;
ArrayList<VoiceHint> list = new ArrayList<VoiceHint>();
List<VoiceHint> list = new ArrayList<VoiceHint>();
public void setTransportMode(boolean isCar, boolean isBike) {
transportMode = isCar ? "car" : (isBike ? "bike" : "foot");