* use a local variable (best practices)
* Add OpenStreetMap notes as overlay.
This commit adds a new layer which renders OpenStreetMap notes in the
current view.
The layer can be activated via the "More" button in the layers sidebar.
Fixes#439
* search favorites
Adds the ability to save search terms, use this for autoexpand during
typing in searchbox or select from whole list
* moved class vars to contructor
Co-authored-by: Karl Schweiger <kschweiger@directbox.com>
- the tooltip shows instantly when hovering a POI icon with the mouse cursor
- the content is the same as for the popup, except for the action button (“delete”) as the button isn't reachable by the mouse (the tooltip disappears when the mouse cursor leaves the icon area)
- (maybe we should add a hint to the tooltip, e.g. “Click icon for actions” (TBD))
- the tooltip is only attached to POI icons on devices without a touch interface, i. e. when `BR.Browser.touch` is `false`
- the tooltip is removed when the icon is clicked, otherwise tooltip and popup would be visible at the same time
- the tooltip is enabled again when the popup is closed
where iD Tagging Schema references "fas-*" icons.
For now, only use selected FA 5 SVG files for overpass layers (without loading any FA 5 JS, CSS or font) and stick with FA 4.7 for everything else.
Users might want to assign custom tracknames, which requires deleting the
default name either entirely or parts of it.
By pre-selecting parts of the trackname, users can start typing right away
after opening the dialog. `Ctrl+A` to select everything is still possible,
but keeping the distance in the filename by default comes in handy,
e.g. when using a file manager not displaying the track length.
NB: Might need adaptation once trackname validation becomes less strict,
i.e. currently "(" and "->" as specified in the message catalog are replaced
with ' - ' by the validator before being inserted into the dialog.
Test Plan:
- Open "Export" dialog ("Location - Other Location - 2km")
- Open "Export" dialog for roundtrip ("Location - 1km")
- In both cases the complete trackname except for the distance
information (including separator) should be selected.
- No unwanted behaviour even if Nominatim is slow or down.
After invoking a shortcut, some dialogs required pressing `Tab`
or using the mouse until focus was moved to the primary input field.
By moving the focus automatically, users can start typing right away.
This is particularly useful in conjunction with the `Return` key for
confirming the dialog.
Test Plan:
- Press `X` to open "Export" dialog:
"Name" field has focus.
- Press `Shift+O` to open "Load track as route":
"Trackfile" is focussed, file dialog opens with `Space`.
- Check "Load no-go area" dialog.
- Check "POI name" dialog.
After ca53080e added Return key handling to the "Delete route" dialog, only
the "Load no-go areas" and "Load track as route" dialogs were still missing
similar functionality.
The implementation is based on 2a431932.
Test Plan:
- Open "Load no-go areas" or "Load track as route" dialog.
- Press Space or Return to open file dialog, choose file,
Tab out of file input and press Return to confirm modal.
- Notice not having to Tab to the respective confirmation button.
5b52abc1 copied `<label>` and `<input>` from the `loadedittrackForm` for
consistency, but missed to add some corresponding code to `NoGoAreas.js`.
After completing the implementation, the filename for loading no-go areas is now
displayed after selecting a file just like in the "Load track as route" dialog.
Test Plan:
- Open "Load no-go areas" dialog.
- Browse and select file.
- The filename should now be shown next to "Browse".
- "Load Track as Route" is now triggered by pressing `Shift-O`
- "Load No-Go-Areas" is now triggered by pressing `Shift-N`
- tooltip for navbar link is updated an ready for translation
After opening the "delete route" dialog the primary action button gets the
current focus. So it's possible to confirm resetting the route by pressing
"Enter".
bootbox had to be updated to to achieve this (in prior versions of bootbox the
needed callback didn't exist).
see #385
