ben/brouter-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Avoid what's new content blinking

Browse source
This commit is contained in:
Gautier P 2021-03-26 16:19:33 +01:00
parent 268525269b
commit dee2515592
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
js/WhatsNew.js
View file

@ -1,4 +1,6 @@
BR.WhatsNew = { BR.WhatsNew = {
newOnly: undefined,
init: function () { init: function () {
var self = this; var self = this;
self.dismissableMessage = new BR.Message('whats_new_message', { self.dismissableMessage = new BR.Message('whats_new_message', {
@ -7,13 +9,15 @@ BR.WhatsNew = {
if (BR.Util.localStorageAvailable()) { if (BR.Util.localStorageAvailable()) {
localStorage.setItem('changelogVersion', self.getLatestVersion()); localStorage.setItem('changelogVersion', self.getLatestVersion());
} }
// next time popup is open, by default we will see everything
self.prepare(false);
}, },
}); });
$('#whatsnew').on('shown.bs.modal', function () { $('#whatsnew').on('shown.bs.modal', function () {
self.dismissableMessage.hide(); self.dismissableMessage.hide();
}); });
$('#whatsnew').on('hidden.bs.modal', function () {
// next time popup is open, by default we will see everything
self.prepare(false);
});
if (!self.getCurrentVersion() && BR.Util.localStorageAvailable()) { if (!self.getCurrentVersion() && BR.Util.localStorageAvailable()) {
localStorage.setItem('changelogVersion', self.getLatestVersion()); localStorage.setItem('changelogVersion', self.getLatestVersion());
} }
@ -36,15 +40,21 @@ BR.WhatsNew = {
}, },
hasNewVersions: function () { hasNewVersions: function () {
return this.getCurrentVersion() && this.getCurrentVersion() < this.getLatestVersion(); return this.getCurrentVersion() && this.getCurrentVersion() !== this.getLatestVersion();
}, },
prepare: function (newOnly) { prepare: function (newOnly) {
if (newOnly === this.newOnly) {
// do not rebuild modal content unnecessarily
return;
}
this.newOnly = newOnly;
var container = document.querySelector('#whatsnew .modal-body'); var container = document.querySelector('#whatsnew .modal-body');
var cl = BR.changelog; var cl = BR.changelog;
if (newOnly && this.getCurrentVersion()) { if (newOnly && this.getCurrentVersion()) {
var head = '<h2 id="' + this.getCurrentVersion() + '">'; var head = '<h2 id="' + this.getCurrentVersion() + '">';
cl = cl.substring(0, cl.indexOf(head)); var idx = cl.indexOf(head);
if (idx >= 0) cl = cl.substring(0, idx);
} }
container.innerHTML = cl; container.innerHTML = cl;
}, },