From 4892c2a1db2022bf7f4e8378f50ea3c3b486a1da Mon Sep 17 00:00:00 2001
From: Norbert Renner <norbert.renner@gmx.de>
Date: Tue, 30 Jun 2020 21:35:51 +0200
Subject: [PATCH] Don't update TrackAnalysis when tab is hidden

- add missing show/hide methods called by sidebar and maintain active state
- rename inconsistent tab id
---
 index.html                  |  4 ++--
 js/control/TrackAnalysis.js | 26 ++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/index.html b/index.html
index 96d26d7..80a0aba 100644
--- a/index.html
+++ b/index.html
@@ -791,7 +791,7 @@
                     </li>
                     <li>
                         <a
-                            href="#tab_statistics"
+                            href="#tab_analysis"
                             role="tab"
                             data-i18n="[title]sidebar.tab-tooltip"
                             data-i18n-options='{
@@ -995,7 +995,7 @@
                             <div id="itinerary" class="flexcolumn flexgrow"></div>
                         </div>
 
-                        <div class="leaflet-sidebar-pane" id="tab_statistics">
+                        <div class="leaflet-sidebar-pane" id="tab_analysis">
                             <h1 class="leaflet-sidebar-header">
                                 <span data-i18n="sidebar.analysis.title">Analysis</span>
                                 <span class="leaflet-sidebar-close"><i class="fa fa-caret-right"></i></span>
diff --git a/js/control/TrackAnalysis.js b/js/control/TrackAnalysis.js
index 7c35445..5fe4c46 100644
--- a/js/control/TrackAnalysis.js
+++ b/js/control/TrackAnalysis.js
@@ -50,6 +50,28 @@ BR.TrackAnalysis = L.Class.extend({
      */
     trackPolyline: null,
 
+    /**
+     * true when tab is shown, false when hidden
+     *
+     * @type {boolean}
+     */
+    active: false,
+
+    /**
+     * Called by BR.Sidebar when tab is activated
+     */
+    show: function() {
+        this.active = true;
+        this.options.requestUpdate(this);
+    },
+
+    /**
+     * Called by BR.Sidebar when tab is deactivated
+     */
+    hide: function() {
+        this.active = false;
+    },
+
     /**
      * Everytime the track changes this method is called:
      *
@@ -63,6 +85,10 @@ BR.TrackAnalysis = L.Class.extend({
      * @param {Array} segments
      */
     update: function(polyline, segments) {
+        if (!this.active) {
+            return;
+        }
+
         if (segments.length === 0) {
             $('#track_statistics').html('');
             return;