ben/brouter-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix broken route segment coloring (#250)

Browse source 
- with var instead of const all callbacks referenced last value in loop,
add closure
- cloning by property overwrites default when undefined, use L.extend
for Object.assign
This commit is contained in:
Norbert Renner 2019-11-07 18:34:01 +01:00
parent 4676c3dcd0
commit 0809b17577
1 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
js/plugin/RoutingPathQuality.js
View file

@ -88,10 +88,12 @@ BR.RoutingPathQuality = L.Control.extend({
stateName: keys[i],
icon: provider.icon,
title: provider.title,
onClick: function(btn) {
btn.state(nextState);
self.setProvider(nextState);
}
onClick: (function(state) {
return function(btn) {
btn.state(state);
self.setProvider(state);
};
})(nextState)
});
}
@ -146,12 +148,7 @@ var HotLineQualityProvider = L.Class.extend({
}
if (flatLines.length > 0) {
var hotlineOptions = {
min: this.hotlineOptions.min,
max: this.hotlineOptions.max,
palette: this.hotlineOptions.palette,
renderer: this.hotlineOptions.renderer
};
var hotlineOptions = L.extend({}, this.hotlineOptions);
if (!hotlineOptions.min && !hotlineOptions.max) {
var minMax = this._calcMinMaxValues(flatLines);
hotlineOptions.min = minMax.min;